Alan Gates updated PIG-712:

    Status: Open  (was: Patch Available)

The patch looks good.  A couple of comments:

1) You set up a set of supported types at the beginning just for error 
checking.  As you do this in static code, this imposes a cost on pig every time 
the jar is loaded.  It would be better to do this with enums so they don't need 
to be loaded or if you want to load them dynamically do a check when the set is 
used to see if it's been loaded and if not load it.

2) There's no need for getTypeString().  Use DataType.findTypeName().

> Need utilities to create schemas for bags and tuples
> ----------------------------------------------------
>                 Key: PIG-712
>                 URL: https://issues.apache.org/jira/browse/PIG-712
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.2.0
>            Reporter: Santhosh Srinivasan
>            Priority: Minor
>             Fix For: 0.3.0
>         Attachments: Pig_712_Patch_Merged.txt
> Pig should provide utilities to create bag and tuple schemas. Currently, 
> users return schemas in outputSchema method and end up with very verbose 
> boiler plate code. It will be very nice if Pig encapsulates the boiler plate 
> code in utility methods.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to