Hadoop QA commented on PIG-814:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 777334.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> Make Binstorage more robust when data contains record markers
> -------------------------------------------------------------
>                 Key: PIG-814
>                 URL: https://issues.apache.org/jira/browse/PIG-814
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.2.1
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: 0.3.0
>         Attachments: PIG-814.patch
> When the inputstream for BinStorage is at a position where the data has the 
> record marker sequence, the code incorrectly assumes that it is at the 
> beginning of a record (tuple) and calls DataReaderWriter.readDatum() trying 
> to read the tuple. The problem is more likely when RandomSampleLoader (used 
> in order by implementation) skips the input stream for sampling and calls 
> Binstorage.getNext(). The code should be more robust in such cases

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to