Pradeep Kamath commented on PIG-926:

In MRCompiler:
You should change:
 indexerArgs[0] = rightLoader.getLFile().getFuncName();
 indexerArgs[0] = rightLoader.getLFile().getFuncSpec().toString();
to handle the case where the loader may have constructor args (like 
PigStorage(",") - PigStorage with comma as delim)

In the error message when the loader does not implement SamplableLoader, you 
can change:
This loader doesn't implement it.
"The loader specified in " + indexerArgs[0] + " doesn't implement it"

Otherwise looks good.

> Merge-Join phase 2
> ------------------
>                 Key: PIG-926
>                 URL: https://issues.apache.org/jira/browse/PIG-926
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>            Priority: Minor
>         Attachments: mj_phase2_1.patch
> This jira is created to keep track of phase-2 work for MergeJoin. Various 
> limitations exist in phase-1 for Merge Join which are listed on: 
> http://wiki.apache.org/pig/PigMergeJoin Those will be addressed here.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to