[ 
https://issues.apache.org/jira/browse/PIG-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Kamath updated PIG-963:
-------------------------------

    Attachment: PIG-963-2.patch

Attached new patch with the only diff to address the findbugs warning - 
findbugs does not like that t1 is null and then we are using it in the next 
comparison - so switching the conditions:
{noformat}
[prade...@afterside:~/dev/pig-commit/PIG-963/trunk]diff 
/homes/pradeepk/dev/pig-apache/pig/trunk/PIG-963.patch 
/homes/pradeepk/dev/pig-apache/pig/trunk/PIG-963-2.patch 
651c651
< +        if(t1 == null && t1 == t2) {
---
> +        if(t1 == t2 && t1 == null) {

{noformat}

> Join in local mode matches null keys
> ------------------------------------
>
>                 Key: PIG-963
>                 URL: https://issues.apache.org/jira/browse/PIG-963
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-963-2.patch, PIG-963.patch
>
>
> Semantics of join and cogroup dictate that null values for the keys from 
> different inputs are NOT supposed to match. This is true in map reduce mode 
> but local mode incorrectly matches these records.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to