Hadoop QA commented on PIG-1018:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 825308.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    -1 release audit.  The applied patch generated 315 release audit warnings 
(more than the trunk's current 309 warnings).

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Release audit warnings: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> FINDBUGS: NM_FIELD_NAMING_CONVENTION: Field names should start with a lower 
> case letter
> ---------------------------------------------------------------------------------------
>                 Key: PIG-1018
>                 URL: https://issues.apache.org/jira/browse/PIG-1018
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1018.patch
> Nm    The field name 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.LogToPhyTranslationVisitor.LogToPhyMap
>  doesn't start with a lower case letter
> Nm    The method name 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.CreateTuple(Object[])
>  doesn't start with a lower case letter
> Nm    The class name 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.util.operatorHelper
>  doesn't start with an upper case letter
> Nm    Class org.apache.pig.impl.util.WrappedIOException is not derived from 
> an Exception, even though it is named as such
> Nm    The method name 
> org.apache.pig.pen.EquivalenceClasses.GetEquivalenceClasses(LogicalOperator, 
> Map) doesn't start with a lower case letter
> Nm    The field name org.apache.pig.pen.util.DisplayExamples.Result doesn't 
> start with a lower case letter
> Nm    The method name 
> org.apache.pig.pen.util.DisplayExamples.PrintSimple(LogicalOperator, Map) 
> doesn't start with a lower case letter
> Nm    The method name 
> org.apache.pig.pen.util.DisplayExamples.PrintTabular(LogicalPlan, Map) 
> doesn't start with a lower case letter
> Nm    The method name 
> org.apache.pig.tools.parameters.TokenMgrError.LexicalError(boolean, int, int, 
> int, String, char) doesn't start with a lower case letter

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to