[ 
https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766303#action_12766303
 ] 

Hadoop QA commented on PIG-1009:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12422166/PIG-1009.patch
  against trunk revision 825601.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/83/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/83/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/83/console

This message is automatically generated.

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS    org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail 
> to close stream
> OS    org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may 
> fail to close stream
> OS    
> org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) 
> may fail to close stream
> OS    org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to 
> close stream
> OS    
> org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String)
>  may fail to close stream
> OS    
> org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String)
>  may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to