[ https://issues.apache.org/jira/browse/PIG-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768949#action_12768949 ]
Daniel Dai commented on PIG-1032: --------------------------------- +1. Target findbugs warnings suppressed. > FINDBUGS: DM_STRING_CTOR: Method invokes inefficient new String(String) > constructor > ----------------------------------------------------------------------------------- > > Key: PIG-1032 > URL: https://issues.apache.org/jira/browse/PIG-1032 > Project: Pig > Issue Type: Improvement > Reporter: Olga Natkovich > Attachments: PIG-1032.patch > > > Dm Method > org.apache.pig.backend.executionengine.PigSlice.init(DataStorage) invokes > toString() method on a String > Dm > org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.copyHadoopConfLocally(String) > invokes inefficient new String(String) constructor > Dm > org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.Launcher.getFirstLineFromMessage(String) > invokes inefficient new String(String) constructor > Dm > org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.BinaryComparisonOperator.initializeRefs() > invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead > Dm > org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.ExpressionOperator.clone() > invokes inefficient new String(String) constructor > Dm > org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.POCast.getNext(String) > invokes inefficient new String(String) constructor > Dm > org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.PONot.getNext(Boolean) > invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead > Dm > org.apache.pig.backend.hadoop.executionengine.physicalLayer.plans.PhysicalPlan.clone() > invokes inefficient new String(String) constructor > Dm new org.apache.pig.data.TimestampedTuple(String, String, int, > SimpleDateFormat) invokes inefficient new String(String) constructor > Dm org.apache.pig.impl.io.PigNullableWritable.toString() invokes > inefficient new String(String) constructor > Dm org.apache.pig.impl.logicalLayer.LOForEach.clone() invokes inefficient > Boolean constructor; use Boolean.valueOf(...) instead > Dm org.apache.pig.impl.logicalLayer.LOGenerate.clone() invokes inefficient > Boolean constructor; use Boolean.valueOf(...) instead > Dm org.apache.pig.impl.logicalLayer.LogicalPlan.clone() invokes > inefficient new String(String) constructor > Dm org.apache.pig.impl.logicalLayer.LOSort.clone() invokes inefficient > Boolean constructor; use Boolean.valueOf(...) instead > Dm > org.apache.pig.impl.logicalLayer.optimizer.ImplicitSplitInserter.transform(List) > invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead > Dm > org.apache.pig.impl.logicalLayer.RemoveRedundantOperators.visit(LOProject) > invokes inefficient new String(String) constructor > Dm org.apache.pig.impl.logicalLayer.schema.Schema.getField(String) invokes > inefficient new String(String) constructor > Dm org.apache.pig.impl.logicalLayer.schema.Schema.reconcile(Schema) > invokes inefficient new String(String) constructor > Dm > org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastForEachInBetweenIfNecessary(LogicalOperator, > LogicalOperator, Schema) invokes inefficient Boolean constructor; use > Boolean.valueOf(...) instead] > Dm > org.apache.pig.impl.util.SpillableMemoryManager.handleNotification(Notification, > Object) forces garbage collection; extremely dubious except in benchmarking > code > Dm org.apache.pig.pen.AugmentBaseDataVisitor.GetLargerValue(Object) > invokes inefficient new String(String) constructor > Dm org.apache.pig.pen.AugmentBaseDataVisitor.GetSmallerValue(Object) > invokes inefficient new String(String) constructor > Dm org.apache.pig.tools.cmdline.CmdLineParser.getNextOpt() invokes > inefficient new String(String) constructor > Dm org.apache.pig.tools.parameters.PreprocessorContext.substitute(String) > invokes inefficient new String(String) constructor -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.