[ https://issues.apache.org/jira/browse/PIG-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1059: -------------------------------- Attachment: PIG-1059.patch > FINDBUGS: remaining Bad practice + Multithreaded correctness Warning > -------------------------------------------------------------------- > > Key: PIG-1059 > URL: https://issues.apache.org/jira/browse/PIG-1059 > Project: Pig > Issue Type: Improvement > Reporter: Olga Natkovich > Assignee: Olga Natkovich > Attachments: PIG-1059.patch > > > IS Inconsistent synchronization of > org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodConfDir; > locked 66% of time > IS Inconsistent synchronization of > org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodProcess; > locked 80% of time > IS Inconsistent synchronization of > org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.remoteHodConfDir; > locked 88% of time > IS Inconsistent synchronization of > org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POStream.initialized; > locked 50% of time > UG > org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getAggregate() > is unsynchronized, > org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setAggregate(boolean) > is synchronized > UG > org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getReporter() > is unsynchronized, > org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setReporter(Reporter) > is synchronized > BC Equals method for org.apache.pig.builtin.PigStorage assumes the > argument is of type PigStorage > BC Equals method for > org.apache.pig.impl.streaming.StreamingCommand$HandleSpec assumes the > argument is of type StreamingCommand$HandleSpec > DP org.apache.pig.data.BagFactory.getInstance() creates a > java.net.URLClassLoader classloader, which should be performed within a > doPrivileged block > DP org.apache.pig.data.TupleFactory.getInstance() creates a > java.net.URLClassLoader classloader, which should be performed within a > doPrivileged block > DP org.apache.pig.impl.PigContext.createCl(String) creates a > java.net.URLClassLoader classloader, which should be performed within a > doPrivileged block > DP org.apache.pig.impl.util.JarManager.createCl(String, PigContext) > creates a java.net.URLClassLoader classloader, which should be performed > within a doPrivileged block > Eq org.apache.pig.data.DistinctDataBag$DistinctDataBagIterator$TContainer > defines compareTo(DistinctDataBag$DistinctDataBagIterator$TContainer) and > uses Object.equals() > Eq org.apache.pig.data.SingleTupleBag defines compareTo(Object) and uses > Object.equals() > Eq org.apache.pig.data.SortedDataBag$SortedDataBagIterator$PQContainer > defines compareTo(SortedDataBag$SortedDataBagIterator$PQContainer) and uses > Object.equals() > Eq org.apache.pig.data.TargetedTuple defines compareTo(Object) and uses > Object.equals() > HE > org.apache.pig.backend.hadoop.executionengine.physicalLayer.plans.PhysicalPlan > defines equals and uses Object.hashCode() > HE > org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POCogroup$groupComparator > defines equals and uses Object.hashCode() > HE org.apache.pig.builtin.BinaryStorage defines equals and uses > Object.hashCode() > HE org.apache.pig.builtin.BinStorage defines equals and uses > Object.hashCode() > HE org.apache.pig.builtin.PigStorage defines equals and uses > Object.hashCode() > HE org.apache.pig.data.InternalSortedBag$DefaultComparator defines equals > and uses Object.hashCode() > HE org.apache.pig.data.NonSpillableDataBag defines equals and uses > Object.hashCode() > HE org.apache.pig.data.SortedDataBag$DefaultComparator defines equals and > uses Object.hashCode() > HE org.apache.pig.impl.streaming.StreamingCommand$HandleSpec defines > equals and uses Object.hashCode() > Nm > org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit) > doesn't override method in superclass because parameter type > org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit > doesn't match superclass parameter type > org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit > Nm > org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit) > doesn't override method in superclass because parameter type > org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit > doesn't match superclass parameter type > org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit > RV > org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.deleteLocalDir(File) > ignores exceptional return value of java.io.File.delete() > RV org.apache.pig.backend.local.datastorage.LocalPath.delete() ignores > exceptional return value of java.io.File.delete() > RV org.apache.pig.data.DefaultAbstractBag.clear() ignores exceptional > return value of java.io.File.delete() > RV org.apache.pig.data.DefaultAbstractBag.finalize() ignores exceptional > return value of java.io.File.delete() > RV org.apache.pig.impl.io.FileLocalizer.create(String, boolean, > PigContext) ignores exceptional return value of java.io.File.mkdirs() -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.