[
https://issues.apache.org/jira/browse/PIG-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771736#action_12771736
]
Hadoop QA commented on PIG-1040:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423618/PIG-1040.patch
against trunk revision 831051.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 311 release audit warnings
(more than the trunk's current 301 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/33/testReport/
Release audit warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/33/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/33/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/33/console
This message is automatically generated.
> FINDBUGS: MS_SHOULD_BE_FINAL: Field isn't final but should be
> -------------------------------------------------------------
>
> Key: PIG-1040
> URL: https://issues.apache.org/jira/browse/PIG-1040
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Attachments: PIG-1040.patch
>
>
> MS
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler.USER_COMPARATOR_MARKER
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.WeightedRangePartitioner.weightedParts
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce.sJobConf
> isn't final and can't be protected from malicious code
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.POProject.bagFactory
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.reporter
> isn't final and can't be protected from malicious code
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.pigLogger
> should be package protected
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBag
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyBool
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDBA
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyDouble
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyFloat
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyInt
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyLong
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyMap
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyString
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.dummyTuple
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.mTupleFactory
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POLocalRearrange.mTupleFactory
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mBagFactory
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPackage.mTupleFactory
> isn't final but should be
> MS
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POPreCombinerLocalRearrange.mTupleFactory
> isn't final but should be
> MS org.apache.pig.builtin.PigDump.recordDelimiter isn't final but should be
> MS org.apache.pig.impl.builtin.GFCross.DEFAULT_PARALLELISM isn't final but
> should be
> MS org.apache.pig.impl.logicalLayer.LogicalPlanBuilder.classloader isn't
> final and can't be protected from malicious code
> MS org.apache.pig.impl.logicalLayer.LogicalPlanCloneHelper.mOpToCloneMap
> should be package protected
> MS
> org.apache.pig.impl.logicalLayer.schema.Schema$FieldSchema.canonicalNamer
> isn't final but should be
> MS
> org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.castLookup
> isn't final but should be
> MS org.apache.pig.impl.plan.OperatorPlan.log isn't final but should be
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
