[ 
https://issues.apache.org/jira/browse/PIG-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772210#action_12772210
 ] 

Hadoop QA commented on PIG-1058:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12423734/PIG-1058.patch
  against trunk revision 831481.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/37/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/37/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/37/console

This message is automatically generated.

> FINDBUGS: remaining "Correctness Warnings"
> ------------------------------------------
>
>                 Key: PIG-1058
>                 URL: https://issues.apache.org/jira/browse/PIG-1058
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Olga Natkovich
>            Assignee: Olga Natkovich
>         Attachments: PIG-1058.patch
>
>
> BC    Impossible cast from java.lang.Object[] to java.lang.String[] in 
> org.apache.pig.PigServer.listPaths(String)
> EC    Call to equals() comparing different types in 
> org.apache.pig.impl.plan.Operator.equals(Object)
> GC    java.lang.Byte is incompatible with expected argument type 
> java.lang.Integer in 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.plans.POPackageAnnotator$LoRearrangeDiscoverer.visitLocalRearrange(POLocalRearrange)
> IL    There is an apparent infinite recursive loop in 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POCogroup$groupComparator.equals(Object)
> INT   Bad comparison of nonnegative value with -1 in 
> org.apache.tools.bzip2r.CBZip2InputStream.bsR(int)
> INT   Bad comparison of nonnegative value with -1 in 
> org.apache.tools.bzip2r.CBZip2InputStream.getAndMoveToFrontDecode()
> INT   Bad comparison of nonnegative value with -1 in 
> org.apache.tools.bzip2r.CBZip2InputStream.getAndMoveToFrontDecode()
> MF    Field ConstantExpression.res masks field in superclass 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator
> Nm    
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
> Nm    
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.NoopStoreRemover$PhysicalRemover.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
> NP    Possible null pointer dereference of ? in 
> org.apache.pig.impl.logicalLayer.optimizer.PushDownForeachFlatten.check(List)
> NP    Possible null pointer dereference of lo in 
> org.apache.pig.impl.logicalLayer.optimizer.StreamOptimizer.transform(List)
> NP    Possible null pointer dereference of 
> Schema$FieldSchema.Schema$FieldSchema.alias in 
> org.apache.pig.impl.logicalLayer.schema.Schema.equals(Schema, Schema, 
> boolean, boolean)
> NP    Possible null pointer dereference of Schema$FieldSchema.alias in 
> org.apache.pig.impl.logicalLayer.schema.Schema$FieldSchema.equals(Schema$FieldSchema,
>  Schema$FieldSchema, boolean, boolean)
> NP    Possible null pointer dereference of inp in 
> org.apache.pig.impl.streaming.ExecutableManager$ProcessInputThread.run()
> RCN   Nullcheck of pigContext at line 123 of value previously dereferenced in 
> org.apache.pig.impl.util.JarManager.createJar(OutputStream, List, PigContext)
> RV    
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.fixUpDomain(String,
>  Properties) ignores return value of java.net.InetAddress.getByName(String)
> RV    Bad attempt to compute absolute value of signed 32-bit hashcode in 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.SkewedPartitioner.getPartition(PigNullableWritable,
>  Writable, int)
> RV    Bad attempt to compute absolute value of signed 32-bit hashcode in 
> org.apache.pig.impl.plan.DotPlanDumper.getID(Operator)
> UwF   Field only ever set to null: 
> org.apache.pig.impl.builtin.MergeJoinIndexer.dummyTuple

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to