[ 
https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Kamath updated PIG-1094:
--------------------------------

    Attachment: PIG-1094.patch

Attached patch which fixes most test cases which are due to the core changes in 
load store interfaces. As noted in the description, the patch does not address 
specific test failures like those due to local mode, streaming etc not being 
fixed yet to work with the new load store redesign.

 * The patch ensures all tests now compile
 * The main changes were to ensure new interface methods are now used. Also in 
many tests were earlier running in local mode, now they have been changed to 
run in mapreduce mode - these are tests not specific to local mode - so the 
switch should not result in loss of any test coverage. 
 * The patch also fixes LoadCaster related changes to POCast and related tests
 * TestPigLineRecordReader.java and TestStreaming have been excluded from 
compile-test and test-core targets since local mode and streaming needs to be 
fixed for them to work

Here are the results from running test-patch ant target locally:
{noformat}
   [exec] 
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 77 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
{noformat}

I will add a comment separately on what tests still fail and which area of the 
code needs to be fixed to address them.

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit 
> test failures due to interface changes. This jira is to track the task of 
> making the common case unit tests work with the new interfaces. Some aspects 
> of the new proposal like using LoadCaster interface for casting, making local 
> mode work have not been completed yet. Tests which are failing due to those 
> reasons will not be fixed in this jira and addressed in the jiras 
> corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to