Pradeep Kamath commented on PIG-1088:

The name getPosition() seems a little misleading for a method returning a 
WritableComparable - the name getPosition() would
typically imply an "int" or "long" return value referring to some position - 
how does getSplitComparable() sound?
If getSplitComparable sounds better, should we also change FilePosition to 

Since most methods in LoadFunc are self contained in terms of input arguments, 
I am wondering if the above method
should take a PigSplit as an argument - also hints to the implementer that the 
return value should be based on the

In ReadToEndLoader:
  236     @Override                                                             
  237     public InputFormat getInputFormat() throws IOException {              
  238         return wrappedLoadFunc.getInputFormat();
  239     }
This was returning null previously because ReadToEndLoader.getInputFormat() 
should never be called and if called
should result in an error. Returning the underlying LoadFunc's inputFormat 
could result in a use of ReadToEndLoader
in a fashion for which it was not designed. The getCaster() can return the 
underlying LoadFunc's getCaster() though
a call to ReadToEndLoader.getCaster() is also not anticipated. ReadToEndLoader 
should only be used in internal pig
code to read side file - so these two methods should never get called - hence 
originally they were returning null.

In DataType.java, should findType(Type t), genAllTypes() genAllTypeNames, 
findTypeName() methods be updated to know
about GENERIC_WRITABLECOMPARABLE? These methods do seem to be aware of internal 
types like INTERNAL_MAP.

BinStorage should also be changed in a fashion similar to PigStorage

> change merge join and merge join indexer to work with new LoadFunc interface
> ----------------------------------------------------------------------------
>                 Key: PIG-1088
>                 URL: https://issues.apache.org/jira/browse/PIG-1088
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>         Attachments: PIG-1088.patch

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to