[ https://issues.apache.org/jira/browse/PIG-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782693#action_12782693 ]
Hadoop QA commented on PIG-990: ------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426160/pinned_options_3.patch against trunk revision 884235. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/55/testReport/ Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/55/console This message is automatically generated. > Provide a way to pin LogicalOperator Options > -------------------------------------------- > > Key: PIG-990 > URL: https://issues.apache.org/jira/browse/PIG-990 > Project: Pig > Issue Type: Bug > Components: impl > Reporter: Dmitriy V. Ryaboy > Assignee: Dmitriy V. Ryaboy > Priority: Minor > Fix For: 0.7.0 > > Attachments: pinned_options.patch, pinned_options_2.patch, > pinned_options_3.patch > > > This is a proactive patch, setting up the groundwork for adding an optimizer. > Some of the LogicalOperators have options. For example, LOJoin has a variety > of join types (regular, fr, skewed, merge), which can be set by the user or > chosen by a hypothetical optimizer. If a user selects a join type, pig > philoophy guides us to always respect the user's choice and not explore > alternatives. Therefore, we need a way to "pin" options. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.