Hadoop QA commented on PIG-1125:

+1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 888186.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 23 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> [zebra] Using typed APIs for Zebra's Map/Reduce interface
> ---------------------------------------------------------
>                 Key: PIG-1125
>                 URL: https://issues.apache.org/jira/browse/PIG-1125
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Chao Wang
>            Assignee: Chao Wang
>             Fix For: 0.6.0, 0.7.0
>         Attachments: PIG-1125.patch, PIG-1125.patch
> We plan to modify Zebra's M/R interface to use typed APIs, i.e., APIs taking 
> object arguments, instead of String arguments.
> Take TableInputFormat as an example:
> setSchema(jobConf conf, String schema) is changing to setSchema(jobConf conf, 
> ZebraSchemaInfo schemaInfo)
> setProjection(jobConf conf, String projection) is changing to 
> setProjection(jobConf conf, ZebraProjectionInfo projectionInfo)
> and so on.
> Benefits: 1) Typed APIs make it easier to detect usage mistakes earlier and 
> 2) Typed APIs are richer and hide things better.
> In the meanwhile, we plan to make the old APIs deprecated, instead of 
> removing them, for the sake of safety.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to