[
https://issues.apache.org/jira/browse/PIG-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794212#action_12794212
]
Thejas M Nair commented on PIG-1090:
------------------------------------
I have reviewed the changes related to partition filter extraction.
* The case where load statement has a user defined schema with different column
names for partition column needs to be handled.
* src/org/apache/pig/LoadMetadata.java - I think we should document in the
comments that the load function does not have to implement setParitionFilter
even if it implements other parts of LoadMetadata interface. And that it can
communicate this to pig by returning null in getPartitionKeys.
* src/org/apache/pig/Expression.java - in BinaryExpression.toString() , need to
add parenthesis around the arguments , if they are binary expressions so that
the string represents the correct operator precedence as specified in the
filter condition. eg (a = 1 or b = 1) and c = 1 now gets converted to "a = 1 or
b = 1 and c = 1" .
* src/org/apache/pig/Expression.java - in Const.toString() - It will be better
to use single quotes instead of double quotes around string constants, as
string literals in SQL (standard) and pig-latin are single-quoted .
> Update sources to reflect recent changes in load-store interfaces
> -----------------------------------------------------------------
>
> Key: PIG-1090
> URL: https://issues.apache.org/jira/browse/PIG-1090
> Project: Pig
> Issue Type: Sub-task
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Attachments: PIG-1090-2.patch, PIG-1090-3.patch, PIG-1090-4.patch,
> PIG-1090.patch, PIG-1190-5.patch
>
>
> There have been some changes (as recorded in the Changes Section, Nov 2 2009
> sub section of http://wiki.apache.org/pig/LoadStoreRedesignProposal) in the
> load/store interfaces - this jira is to track the task of making those
> changes under src. Changes under test will be addresses in a different jira.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
