[
https://issues.apache.org/jira/browse/PIG-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806197#action_12806197
]
Hadoop QA commented on PIG-977:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431709/pig-977.patch
against trunk revision 904241.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 486 release audit warnings
(more than the trunk's current 485 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/182/testReport/
Release audit warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/182/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/182/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/182/console
This message is automatically generated.
> exit status does not account for JOB_STATUS.TERMINATED
> ------------------------------------------------------
>
> Key: PIG-977
> URL: https://issues.apache.org/jira/browse/PIG-977
> Project: Pig
> Issue Type: Bug
> Reporter: Thejas M Nair
> Assignee: Ashutosh Chauhan
> Fix For: 0.7.0
>
> Attachments: pig-977.patch
>
>
> For determining the exit status of pig query, only JOB_STATUS.FAILED is being
> used and status TERMINATED is ignored.
> I think the reason for this is that in ExecJob.JOB_STATUS only FAILED and
> COMPLETED are being used anywhere. Rest are unused. I think we should comment
> out the unused parts for now to indicate that, or fix the code for
> determining success/failure in GruntParser. executeBatch
> {code}
> public enum JOB_STATUS {
> QUEUED,
> RUNNING,
> SUSPENDED,
> TERMINATED,
> FAILED,
> COMPLETED,
> }
> {code}
> {code}
> private void executeBatch() throws IOException {
> if (mPigServer.isBatchOn()) {
> if (mExplain != null) {
> explainCurrentBatch();
> }
> if (!mLoadOnly) {
> List<ExecJob> jobs = mPigServer.executeBatch();
> for(ExecJob job: jobs) {
> == ====> if (job.getStatus() == ExecJob.JOB_STATUS.FAILED) {
> mNumFailedJobs++;
> if (job.getException() != null) {
> LogUtils.writeLog(
> job.getException(),
>
> mPigServer.getPigContext().getProperties().getProperty("pig.logfile"),
> log,
>
> "true".equalsIgnoreCase(mPigServer.getPigContext().getProperties().getProperty("verbose")),
> "Pig Stack Trace");
> }
> }
> else {
> mNumSucceededJobs++;
> }
> }
> }
> }
> }
> {code}
> Any opinions ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
