[ 
https://issues.apache.org/jira/browse/PIG-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838656#action_12838656
 ] 

Jeff Zhang commented on PIG-259:
--------------------------------

Alan,

In the patch I created a PigStorage constructor with a second argument indicate 
whether to overwrite. And the reason I change the StoreFuncInterface is that 
I'd like the users who want to create customized StoreFunc has the option to 
support overwrite.

Besides I need the overwrite information in InputOutputFileVisitor and 
JobControlCompiler, But in these two classes I only can get StoreFuncInterface. 
One way to work around is to check the class whether it is PigStorage, and then 
cast it to PigStorage, but it seems to me not so friendly and extensible. 

> allow store to overwrite existing directroy
> -------------------------------------------
>
>                 Key: PIG-259
>                 URL: https://issues.apache.org/jira/browse/PIG-259
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: 0.8.0
>            Reporter: Olga Natkovich
>            Assignee: Jeff Zhang
>             Fix For: 0.8.0
>
>         Attachments: Pig_259.patch, Pig_259_2.patch, Pig_259_3.patch, 
> Pig_259_4.patch
>
>
> we have users who are asking for a flag to overwrite existing directory

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to