[ 
https://issues.apache.org/jira/browse/PIG-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839000#action_12839000
 ] 

Ashutosh Chauhan commented on PIG-1251:
---------------------------------------

@Dmitriy

I agree. ResourceSchema encapsulates both SortInfo and PigSchema within it. So, 
SortInfo should not really be exposed. It should be a private member of 
ResourceSchema and where SortInfo is required, it should be accessed via 
ResourceSchema.  I thought about doing all those changes in this patch, but 
changes were more involved then I thought. So, I backed-off to keep changes 
minimal for this patch. We can track that as a separate ticket. 

> Move SortInfo calculation earlier in compilation 
> -------------------------------------------------
>
>                 Key: PIG-1251
>                 URL: https://issues.apache.org/jira/browse/PIG-1251
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>
>         Attachments: pig-1251.patch, pig-1251_1.patch
>
>
> In LSR Pig does Input Output Validation by calling hadoop's checkSpecs() A 
> storefunc might need schema to do such a validation. So, we should call 
> checkSchema() before doing the validation. checkSchema() in turn requires 
> SortInfo which is calculated later in compilation phase. We need to move it 
> earlier in compilation phase. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to