[ 
https://issues.apache.org/jira/browse/PIG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849568#action_12849568
 ] 

Hadoop QA commented on PIG-1317:
--------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12439703/PIG-1317.patch
  against trunk revision 926846.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/247/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/247/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/247/console

This message is automatically generated.

> LOLoad should cache results of LoadMetadata.getSchema() for use in subsequent 
> calls to LOLoad.getSchema() or LOLoad.determineSchema()
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-1317
>                 URL: https://issues.apache.org/jira/browse/PIG-1317
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: 0.7.0
>
>         Attachments: PIG-1317.patch
>
>
> In LOLoad.getProjectionMap(), the private method determineSchema() is called 
> which inturn calls LoadMetadata.getSchema() - the latter call could 
> potentially be expensive if the input file is read to determine the schema or 
> a metadata system is contacted to get the schema - determineSchema() can 
> cache the schema it gets so that subsequent calls use the cached version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to