Cool - one thing though - Piggybank itself does not build in trunk. It must not have built since 0.6, since the load/store func changes went in. Does something need to be done there? Should I submit a patch that removes all the broken UDFs to make ant build in piggybank work on trunk?
To get piggybank to build, I had to remove: ! contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestMultiStorage.java ! contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestSequenceFileLoader.java ! contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestRegExLoader.java ! contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/TestPigStorageSchema.java ! contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/evaluation/string/TestLookupInFiles.java ! contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/evaluation/TestEvalString.java Is this just me, is this fixed on other branches? On Tue, Mar 30, 2010 at 12:30 PM, Alan Gates (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/PIG-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851526#action_12851526] > > Alan Gates commented on PIG-1310: > --------------------------------- > > New patch looks good. Piggybank tests pass. I'm rerunning the patch test > to check things like javac warnings, etc. As long as that all returns > success I'll commit it. Then I'll apply it to 0.7, test it there, and > assuming all is well, commit it there too. > > > ISO Date UDFs: Conversion, Trucation and Date Math > > -------------------------------------------------- > > > > Key: PIG-1310 > > URL: https://issues.apache.org/jira/browse/PIG-1310 > > Project: Pig > > Issue Type: New Feature > > Components: impl > > Reporter: Russell Jurney > > Assignee: Russell Jurney > > Fix For: 0.7.0 > > > > Attachments: joda-mavenstuff.diff, pass.patch > > > > Original Estimate: 168h > > Remaining Estimate: 168h > > > > I've written UDFs to handle loading unix times, datemonth values and ISO > 8601 formatted date strings, and working with them as ISO datetimes using > jodatime. > > The working code is here: > http://github.com/rjurney/oink/tree/master/src/java/oink/udf/isodate/ > > It needs to be documented and tests added, and a couple UDFs are missing, > but these work if you REGISTER the jodatime jar in your script. Hopefully I > can get this stuff in piggybank before someone else writes it this time :) > The rounding also may not be performant, but the code works. > > Ultimately I'd also like to enable support for ISO 8601 durations. > Someone slap me if this isn't done soon, it is not much work and this > should help everyone working with time series. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
