[ https://issues.apache.org/jira/browse/PIG-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854166#action_12854166 ]
Pradeep Kamath commented on PIG-1338: ------------------------------------- +1 - changes look good. A minor comment: Can the following error message be changed from: {noformat} "Cannot find hadoop configurations in classpath." {noformat} to {noformat} "Cannot find hadoop configurations in classpath (neither hadoop-site.xml nor core-site.xml was found in the classpath)." {noformat} > Pig should exclude hadoop conf in local mode > -------------------------------------------- > > Key: PIG-1338 > URL: https://issues.apache.org/jira/browse/PIG-1338 > Project: Pig > Issue Type: Improvement > Components: impl > Affects Versions: 0.7.0 > Reporter: Daniel Dai > Assignee: Daniel Dai > Attachments: PIG-1338-1.patch, PIG-1338-2.patch, PIG-1338-3.patch, > PIG-1338-4.patch, PIG-1338-5.patch, PIG-1338-6.patch > > > Currently, the behavior for hadoop conf look up is: > * in local mode, if there is hadoop conf, bail out; if there is no hadoop > conf, launch local mode > * in hadoop mode, if there is hadoop conf, use this conf to launch Pig; if > no, still launch without warning, but many functionality will go wrong > We should bring it to a more intuitive way, which is: > * in local mode, always launch Pig in local mode > * in hadoop mode, if there is hadoop conf, use this conf to launch Pig; if > no, bail out with a meaningful message -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.