[ 
https://issues.apache.org/jira/browse/PIG-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862518#action_12862518
 ] 

V.V.Chaitanya Krishna commented on PIG-1396:
--------------------------------------------

bq. -1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

Since this is a build change and more specifically, it's a change that is in 
action only while importing to eclipse. So, it cannot be unit-tested, unlike 
other patches.

bq. -1 core tests. The patch failed core unit tests.

I don't think this failure is related to this patch because as mentioned 
before, it's a build change that is used only for eclipse environment issues 
and this should not hinder the running of ant targets that are responsible for 
running testcases.

> eclipse-files target in build.xml fails to generate necessary classes in 
> src-gen
> --------------------------------------------------------------------------------
>
>                 Key: PIG-1396
>                 URL: https://issues.apache.org/jira/browse/PIG-1396
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.8.0
>            Reporter: V.V.Chaitanya Krishna
>            Assignee: V.V.Chaitanya Krishna
>             Fix For: 0.8.0
>
>         Attachments: PIG-1396.patch
>
>
> With PIG-1390 checked in, ant eclipse-files does only the ivy-download part 
> but does not compile and generate the necessary classes in src-gen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to