[ 
https://issues.apache.org/jira/browse/PIG-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866942#action_12866942
 ] 

Hadoop QA commented on PIG-1381:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444335/PIG-1381-4.patch
  against trunk revision 943578.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/328/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/328/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/328/console

This message is automatically generated.

> Need a way for Pig to take an alternative property file
> -------------------------------------------------------
>
>                 Key: PIG-1381
>                 URL: https://issues.apache.org/jira/browse/PIG-1381
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: V.V.Chaitanya Krishna
>             Fix For: 0.7.0, 0.8.0
>
>         Attachments: PIG-1381-1.patch, PIG-1381-2.patch, PIG-1381-3.patch, 
> PIG-1381-4.patch
>
>
> Currently, Pig read the first ever pig.properties in CLASSPATH. Pig has a 
> default pig.properties and if user have a different pig.properties, there 
> will be a conflict since we can only read one. There are couple of ways to 
> solve it:
> 1. Give a command line option for user to pass an additional property file
> 2. Change the name for default pig.properties to pig-default.properties, and 
> user can give a pig.properties to override
> 3. Further, can we consider to use pig-default.xml/pig-site.xml, which seems 
> to be more natural for hadoop community. If so, we shall provide backward 
> compatibility to also read pig.properties, pig-cluster-hadoop-site.xml. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to