[
https://issues.apache.org/jira/browse/PIG-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869708#action_12869708
]
Daniel Dai commented on PIG-1422:
---------------------------------
+1, please commit to the trunk.
> Duplicate code in LOPrinter.java
> --------------------------------
>
> Key: PIG-1422
> URL: https://issues.apache.org/jira/browse/PIG-1422
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: PIG_1422.patch
>
>
> Today when I go through the source code , I find the following duplicate code
> in LOPrinter.java (line 153 --- line 170)
> {code}
> else if(node instanceof LOJoin){
> MultiMap<LogicalOperator, LogicalPlan> plans =
> ((LOJoin)node).getJoinPlans();
> for (LogicalOperator lo : plans.keySet()) {
> // Visit the associated plans
> for (LogicalPlan plan : plans.get(lo)) {
> sb.append(planString(plan));
> }
> }
> }
> else if(node instanceof LOJoin){
> MultiMap<LogicalOperator, LogicalPlan> plans =
> ((LOJoin)node).getJoinPlans();
> for (LogicalOperator lo : plans.keySet()) {
> // Visit the associated plans
> for (LogicalPlan plan : plans.get(lo)) {
> sb.append(planString(plan));
> }
> }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
