[
https://issues.apache.org/jira/browse/PIG-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870796#action_12870796
]
Daniel Dai commented on PIG-1381:
---------------------------------
I reviewed the patch. Command line properties file will override default
properties, and we can have multiple number of -propertyFile entry in command
line. Command line switch is -P or -propertyFile. That's good.
I have a comment for the line:
opts.registerOpt('P', "propertyFile", CmdLineParser.ValueExpected.OPTIONAL);
I think value of "perpertyFile" perperty is not OPTIONAL, should change it to
REQUIRED.
> Need a way for Pig to take an alternative property file
> -------------------------------------------------------
>
> Key: PIG-1381
> URL: https://issues.apache.org/jira/browse/PIG-1381
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: V.V.Chaitanya Krishna
> Fix For: 0.8.0
>
> Attachments: PIG-1381-1.patch, PIG-1381-2.patch, PIG-1381-3.patch,
> PIG-1381-4.patch, PIG-1381-5.patch, PIG-1381_cli_1.patch
>
>
> Currently, Pig read the first ever pig.properties in CLASSPATH. Pig has a
> default pig.properties and if user have a different pig.properties, there
> will be a conflict since we can only read one. There are couple of ways to
> solve it:
> 1. Give a command line option for user to pass an additional property file
> 2. Change the name for default pig.properties to pig-default.properties, and
> user can give a pig.properties to override
> 3. Further, can we consider to use pig-default.xml/pig-site.xml, which seems
> to be more natural for hadoop community. If so, we shall provide backward
> compatibility to also read pig.properties, pig-cluster-hadoop-site.xml.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
