[
https://issues.apache.org/jira/browse/PIG-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871862#action_12871862
]
Ashutosh Chauhan commented on PIG-1347:
---------------------------------------
Patch is pretty straightforward and harmless as it only removes code and does
not add any thing new. Only concern I have is
FileLocalizer.registerDeleteOnFail() is a public method so its possible that
some one using Pig's java api is using this method to do the cleanup himself
previously. So, this can be considered as backward incompatible change. But,
Daniel explained to me that this method was meant for Pig's internal usage and
clean up in any case was taken care by Pig before the recent store func
changes, so user need not to worry about it. So, its extremely unlikely that
someone is using it.
So, +1 on committing.
> Clear up output directory for a failed job
> ------------------------------------------
>
> Key: PIG-1347
> URL: https://issues.apache.org/jira/browse/PIG-1347
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Ashitosh Darbarwar
> Fix For: 0.8.0
>
> Attachments: PIG-1347-1.patch
>
>
> FileLocalizer.deleteOnFail suppose to track the output files need to be
> deleted in case the job fails. However, in the current code base,
> deleteOnFail is dangling. registerDeleteOnFail and triggerDeleteOnFail is
> called by nobody. We need to bring it back.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
