[
https://issues.apache.org/jira/browse/PIG-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890007#action_12890007
]
Richard Ding commented on PIG-1435:
-----------------------------------
Looks good. A few comments:
* The new test class _test/org/apache/pig/test/utils/UPPER.java_ is missing
Apache header and this results in the release audit warning.
* In the test case, the line
{code}
w.println("B = FOREACH A GENERATE UPPER(name);");
{code}
should be replaced by
{code}
w.println("B = FOREACH A GENERATE org.apache.pig.test.utils.UPPER(name);");
{code}
otherwise the builtin UDF UPPER is used and job will succeed.
* Also in the test case, should replace
{code}
if(js.getState().equals("FAILED")){
{code}
with
{code}
if(js.getState().name().equals("FAILED")){
{code}
to perform the string comparison.
* The logging in _MapReduceLauncher_
{code}
log.info("jobs" + job.getAssignedJobID() + " have failed!
{code}
should be written as
{code}
log.info("job " + job.getAssignedJobID() + " has failed!
{code}
> make sure dependent jobs fail when a jon in multiquery fails
> ------------------------------------------------------------
>
> Key: PIG-1435
> URL: https://issues.apache.org/jira/browse/PIG-1435
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Assignee: niraj rai
> Fix For: 0.8.0
>
> Attachments: depJobs.patch, depJobsFailure.patch
>
>
> Currently if one of the MQ jobs fails, Pig tries to run all remainin jobs. As
> the result, if data was partially generated by the failed job, you might get
> incorrect results from dependent jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
