[
https://issues.apache.org/jira/browse/PIG-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900066#action_12900066
]
Thejas M Nair commented on PIG-1524:
------------------------------------
All core, contrib tests pass .
Result of test-patch
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] -1 release audit. The applied patch generated 418 release
audit warnings (more than the trunk's current 415 warnings).
As mentioned earlier, I don't have any new test cases because the counter
values will vary depending on current max memory.
The release audit -1 is caused by java doc jdiff changes.
Patch is ready for review.
> 'Proactive spill count' is misleading
> -------------------------------------
>
> Key: PIG-1524
> URL: https://issues.apache.org/jira/browse/PIG-1524
> Project: Pig
> Issue Type: Bug
> Reporter: Thejas M Nair
> Assignee: Thejas M Nair
> Fix For: 0.8.0
>
> Attachments: PIG-1524.2.patch, PIG-1524.3.patch, PIG-1524.patch
>
>
> InternalCacheBag, InternalSortedBag, InternalDistinctBag increment this
> counter for every record that it writes to disk, once it exceeds the memory
> limit. This number is misleading.
> Instead, this counter should be increment it by 1 for each instance of these
> bags that has spilled to disk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
