[ 
https://issues.apache.org/jira/browse/PIG-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900376#action_12900376
 ] 

Richard Ding commented on PIG-1514:
-----------------------------------

Patch looks good. A couple of comments:

* It would be better to refactor the graph manipulation code into a helper 
class so that the graph transformation routines (such as swap, insert, remove, 
replace, ...) can be shared by all rules.
* Please remove tabs from the file. 

> Migrate logical optimization rule: OpLimitOptimizer
> ---------------------------------------------------
>
>                 Key: PIG-1514
>                 URL: https://issues.apache.org/jira/browse/PIG-1514
>             Project: Pig
>          Issue Type: Sub-task
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.8.0
>
>         Attachments: jira-1514-0.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to