[ 
https://issues.apache.org/jira/browse/PIG-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901992#action_12901992
 ] 

Richard Ding commented on PIG-1551:
-----------------------------------


The typo is still there:

{code}
private static final Class<?> LONG_ARRAY_CLASS = new Long[0].getClass();
{code}

It seems what you want is 

{code}
private static final Class<?> LONG_ARRAY_CLASS = new long[0].getClass();
{code}

so it's consistent with other array classes.

This does raise a question about array parameters: the first form applies to 
methods like _amethod(Long[] nums)_, while the second supports methods like 
_amethod(long[] nums)_. And they are not exchangeable. 

> Improve dynamic invokers to deal with no-arg methods and array parameters
> -------------------------------------------------------------------------
>
>                 Key: PIG-1551
>                 URL: https://issues.apache.org/jira/browse/PIG-1551
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.8.0
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>             Fix For: 0.8.0
>
>         Attachments: PIG-1551.patch, PIG_1551.2.patch
>
>
> PIG-1354 introduced a set of UDFs that can be used to dynamically wrap simple 
> Java methods in a UDF, so that users don't need to create trivial wrappers if 
> they are ok sacrificing some speed.
> This issue is to extend the set of methods that can be wrapped this way to 
> include methods that do not take any arguments, and methods that take arrays 
> of {int,long,float,double,string} as arguments. 
> Arrays are expected to be represented by bags in Pig. Notably, this allows 
> users to wrap statistical functions in o.a.commons.math.stat.StatUtils . 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to