[ https://issues.apache.org/jira/browse/PIG-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917081#action_12917081 ]
Alan Gates commented on PIG-1565: --------------------------------- [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 8 new or modified tests. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] The javadoc warning is: [javadoc] /home/gates/src/pig/PIG-1565/trunk/src/org/apache/pig/builtin/INDEXOF.java:78: warning - Tag @link: can't find INDEX_OF(int, int) in java.lang.String Building Piggybank now fails as well, since some of the ErrorCatchingBase class was moved into main Pig. Also, the patch fails a couple of unit tests in TestStringUDFs. It fails testIndexOf and testLastIndexOf() because it doesn't properly handle the null case. I'll attach the output from running the tests. > additional piggybank datetime and string UDFs > --------------------------------------------- > > Key: PIG-1565 > URL: https://issues.apache.org/jira/browse/PIG-1565 > Project: Pig > Issue Type: Improvement > Reporter: Andrew Hitchcock > Assignee: Andrew Hitchcock > Fix For: 0.8.0 > > Attachments: PIG-1565-1.patch, PIG-1565-2.patch > > > Pig is missing a variety of UDFs that might be helpful for users implementing > Pig scripts. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.