[
https://issues.apache.org/jira/browse/PIG-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546313
]
Patrick Hunt commented on PIG-36:
---------------------------------
Er, ok. So the desired state in this case should be: since this diverges from
the std "stream skip" idiom add these comments to the source so the next guy to
run findbugs will be less likely to flag it. (I'd do it but I'm not a commiter)
> FindBugs: Method ignores results of InputStream.skip()
> ------------------------------------------------------
>
> Key: PIG-36
> URL: https://issues.apache.org/jira/browse/PIG-36
> Project: Pig
> Issue Type: Bug
> Components: impl
> Reporter: Patrick Hunt
>
> InputStreams don't always skip as much as they are asked to skip, need to do
> this in a loop:
> if (toSkip > 0)
> in.skip(toSkip);
> return t;
> Severity and Description Path Resource Location
> Creation Time Id
> M B RR: org.apache.pig.impl.builtin.RandomSampleLoader.getNext() ignores
> result of org.apache.pig.impl.io.BufferedPositionedInputStream.skip(long)
> pig-apache/src/org/apache/pig/impl/builtin RandomSampleLoader.java line
> 49 1196213971062 22891
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
