[ 
https://issues.apache.org/jira/browse/PIG-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555628#action_12555628
 ] 

Benjamin Reed commented on PIG-30:
----------------------------------

Excellent job Alan! That was a lot of work! Just a couple of small comments:

*  Do we need to expose DefaultDataBag, SortedDataBag, and DistinctDataBag? We 
don't want people constructing them directly right? Maybe we should make them 
package protected.

* One reason to expose SortedDataBag would be to get the sort spec. Do we want 
to expose that?

> Get rid of DataBag and always use BigDataBag
> --------------------------------------------
>
>                 Key: PIG-30
>                 URL: https://issues.apache.org/jira/browse/PIG-30
>             Project: Pig
>          Issue Type: Bug
>          Components: data
>            Reporter: Benjamin Reed
>            Assignee: Alan Gates
>         Attachments: bagrewrite.patch
>
>
> We should never use DataBag directly; instead, we should always use 
> BigDataBag. I think we already do this. The problem is that the logic in 
> BigDataBag is hard to follow and it is made more complicated because it 
> subclasses DataBag. We should merge these two classes together.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to