[ 
https://issues.apache.org/jira/browse/PIG-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562212#action_12562212
 ] 

Olga Natkovich commented on PIG-63:
-----------------------------------

Code review:

Overall looks good. One question that I have is about readLine function in 
BufferedPositionedInputStream.java.

I assume that you have a switch statement for performance reason there. Is that 
correct? Also, seems like you would need a break for the default case. 

> PigStorage does not properly handle UTF8 data
> ---------------------------------------------
>
>                 Key: PIG-63
>                 URL: https://issues.apache.org/jira/browse/PIG-63
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>            Assignee: Benjamin Reed
>         Attachments: utf8.patch, utf8.patch, utf8.patch, utf8_v4.patch
>
>
> From Ben:
> I just checked the code and the problem seems to be PigStorage. getNext() uses
> readLine() which does not handle UTF8 correctly. putNext() also uses default 
> encoder rather than UTF8 explicitly.
> Internally and in BinStorage UTF8 appears to be handled correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to