Improve use of StringBuffer in TestBuiltin.java to reduce memory footprint and
increase speed
---------------------------------------------------------------------------------------------
Key: PIG-106
URL: https://issues.apache.org/jira/browse/PIG-106
Project: Pig
Issue Type: Improvement
Affects Versions: 0.1.0
Reporter: Benjamin Francisoud
Priority: Minor
While investigating PIG-99, in TestBuiltin.java line 315:
{code:java}
for (int i = 0; i < LOOP_COUNT; i++) {
for (int j = 0; j < LOOP_COUNT; j++) {
sb.append(i + "\t" + i + "\t" + j % 2 + "\n");
}
}
{code}
doing "i + "\t" + i + "\t" + j % 2 + "\n"" creates temporary String(s) reducing
the advantages of using a StringBuffer.
Could be replace with:
{code:java}
for (int i = 0; i < LOOP_COUNT; i++) {
for (int j = 0; j < LOOP_COUNT; j++) {
sb.append(i);
sb.append("\t");
sb.append(i);
sb.append("\t");
sb.append(j % 2);
sb.append("\n");
}
}
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
