[
https://issues.apache.org/jira/browse/PIG-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574254#action_12574254
]
Johannes Zillmann commented on PIG-100:
---------------------------------------
{noformat}
try {
plan = parser.Parse();
} catch (ParseException e) {
log.error(e.getMessage());
log.debug(e);
}
{noformat}
Hi Benjamin, i'm very much aginst this kind of error handling.
First of all, i think the user of pig (or the caller of
PigServer#registerQuery()) should be in control wether or not he want to stop
the execution of his process when the registration of a query failed. I think
in a lot of cases the user wants to fail fast. Grunt represents the other side.
So if this error handling is appropriate for grunt, it should move to grunt.
Secondly the 2 log statments would lead to duplicate logging, would'nt they ?
> Tests: NullPointerException parser.QueryParser.Alias(QueryParser.java:471)
> --------------------------------------------------------------------------
>
> Key: PIG-100
> URL: https://issues.apache.org/jira/browse/PIG-100
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: PIG-100-tests.log, PIG-100-v01.patch, PIG-100-v02.patch
>
>
> I think the root problem was that I forget to specify the configuration using
> -Djunit.hadoop.conf=hadoop-site.xml while running the tests.
> But the error could be clearer...
> The logs are big so I will provide them in a separate file...
> But the core problem is:
> {noformat}
> [junit] java.lang.NullPointerException
> [junit] at
> org.apache.pig.impl.logicalLayer.parser.QueryParser.Alias(QueryParser.java:471)
> [junit] at
> org.apache.pig.impl.logicalLayer.parser.QueryParser.NestedExpr(QueryParser.java:411)
> [junit] at
> org.apache.pig.impl.logicalLayer.parser.QueryParser.NestedExpr(QueryParser.java:417)
> [junit] at
> org.apache.pig.impl.logicalLayer.parser.QueryParser.GroupItem(QueryParser.java:1027)
> ...
> [junit] org.apache.pig.impl.logicalLayer.parser.ParseException:
> Encountered "group" at line 1, column 9.
> [junit] Was expecting one of:
> [junit] <IDENTIFIER> ...
> [junit] "(" ...
> [junit]
> [junit] at
> org.apache.pig.impl.logicalLayer.parser.QueryParser.generateParseException(QueryParser.java:4142)
> ...
> [junit] org.apache.pig.impl.logicalLayer.parser.ParseException:
> Encountered "generate" at line 1, column 1.
> [junit] Was expecting one of:
> [junit] "load" ...
> [junit] "filter" ...
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
