[
https://issues.apache.org/jira/browse/PIG-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582879#action_12582879
]
Alan Gates commented on PIG-157:
--------------------------------
This patch is big, with several changes in it. When possible, let's try to
break up patches so that their easier to review and apply.
I've broken out the changes in the data directory and the builtin directory and
applied those, along with a few changes of my own. So at this point, the whole
data directory builds, as does the whole pig/builtin (but not pig/impl/builtin
(why do we have two directories named builtin?)) directory. I've added those
directories to the build.xml file. I've also changed build.xml to only run the
unit tests we expect to pass. At the moment that's TestOperatorPlan and
TestBuiltin.
You've also included changes to Operator plan in this patch. I'll take a look
at that tomorrow and see if that can be committed.
As far as the changes for physical operator, I have a few questions/comments:
1) The places you put tests directly in the code should be converted to junit
tests before we commit the patch. This will make it easy for other developers
to run the tests and assure that they haven't broken your code as part of their
changes. When you add these tests, please be sure to add them to build.xml as
part of the tests we expect to pass.
2) Why did you move physical operators from the directory "physicalLayer" to
"physical"? Unless there's a compelling reason, we should keep the same
directory structure.
3) I have no problem with commenting out parts of the code so that we can
compile now. Whenever we do that, let's put a tag there that is easy to find
with a global search. I've been using TODO FIX. If you can change the code in
your patch to include this that will help us find all those locations later.
> Add types and rework execution pipeline
> ---------------------------------------
>
> Key: PIG-157
> URL: https://issues.apache.org/jira/browse/PIG-157
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: Core.patch.zip, patcher.sh
>
>
> This is the tracking bug for the work to add types to pig and rework the
> execution pipeline. Individual components of this work are covered in
> subtasks.
> Functional and design specs for this work are:
> http://wiki.apache.org/pig/PigTypesFunctionalSpec
> http://wiki.apache.org/pig/PigTypesDesign
> http://wiki.apache.org/pig/PigExecutionModel
> This work is being done on the branch types, since it is large and
> disruptive, and we want to be able to do incremental checkins without causing
> issues for the trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
