[ 
https://issues.apache.org/jira/browse/PIG-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583133#action_12583133
 ] 

Benjamin Reed commented on PIG-170:
-----------------------------------

+1 I agree it should be committed. I should also point out that this doesn't 
invalidate the cleanup in the registerSpillable. That code will still clean up 
weak references of bags that have been freed since the last GC, which is 
exactly what it is supposed to do. We do a global cleanup after a GC when our 
threshold callback is invoked.

> Memory manager spills bags in the wrong order
> ---------------------------------------------
>
>                 Key: PIG-170
>                 URL: https://issues.apache.org/jira/browse/PIG-170
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>            Assignee: Amir Youssefi
>         Attachments: compareMemUsage.gif, PIG-170_0_20080327.patch
>
>
> For optimal performance, we want to spill the largest bags first. This is not 
> what is happening right now and could be causing some of our memory issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to