[
https://issues.apache.org/jira/browse/PIG-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charlie Groves updated PIG-55:
------------------------------
Attachment: pig_chunker_split_v5.patch
Sorry about that, forgot to update before adding to the patch. This version
compiles against and passes all tests on trunk as of r643141.
I'm a little surprised to see that all instances of String concatenation using
+ have been replaced with StringBuilder. That's so much harder to read and
Java compiles + concatenation with StringBuffer. While StringBuffer is
synchronized unlike StringBuilder, the JVM is smart enough to realize when a
variable is only accessible from a single thread and optimize most of the
locking penalty away for anything that's heavily accessed. I would expect to
see StringBuilder used in an inner loop, not in exception String construction.
> Allow user control over split creation
> --------------------------------------
>
> Key: PIG-55
> URL: https://issues.apache.org/jira/browse/PIG-55
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.0.0
> Reporter: Charlie Groves
> Fix For: 0.1.0
>
> Attachments: pig_chunker_split.patch, pig_chunker_split_v2.patch,
> pig_chunker_split_v3.patch, pig_chunker_split_v4.patch,
> pig_chunker_split_v5.patch, replaceable_PigSplit.diff,
> replaceable_PigSplit_v2.diff
>
>
> I have a dataset in HDFS that's stored in a file per column that I'd like to
> access from pig. This means I can't use LoadFunc to get at the data as it
> only allows the loader access to a single input stream at a time. To handle
> this usage, I've broken the existing split creation code out into a few
> classes and interfaces, and allowed user specified load functions to be used
> in place of the existing code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
