[
https://issues.apache.org/jira/browse/PIG-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584789#action_12584789
]
Alan Gates commented on PIG-161:
--------------------------------
I've committed Shubham's patch with the arithmetic operators in it. Thanks for
adding the unit tests.
A couple of generic comments:
1) I moved classes named in all caps to initial cap only (eg ADD -> Add). I
know they were named that way previously, but I like to keep class naming
consistent.
2) As we add files, make sure they contain the Apache license header. I
noticed a number of files we've added recently were missing them. I added them.
3) Please be sure your editor is set to indent with spaces, not tabs. I
realized that we've added a number of files lately in various patches that are
indenting via tabs. I converted the files I found.
> Rework physical plan
> --------------------
>
> Key: PIG-161
> URL: https://issues.apache.org/jira/browse/PIG-161
> Project: Pig
> Issue Type: Sub-task
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: arithmeticOperators.patch, Phy_AbsClass.patch,
> pogenerate.patch
>
>
> This bug tracks work to rework all of the physical operators as described in
> http://wiki.apache.org/pig/PigTypesFunctionalSpec
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
