[
https://issues.apache.org/jira/browse/PIG-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586548#action_12586548
]
Alan Gates commented on PIG-161:
--------------------------------
Checked in Shubham's pogenerate patch. Also checked in Shravan's incr3 patch.
A couple of small comments:
1) Shravan, I think your editor is still set to use tabs instead of spaces.
2) We need to make sure to not swallow exception (except where appropriate).
In a few places in the code I've seen where the exception is caught,
e.printStackTrace() is called, and nothing else is done. As a general rule, if
there is really an error, the exception should be passed along. If a new
exception is generated, the old exception should be encapsulated via
initCause(). Just adding the message isn't sufficient. That is:
{code:title=Bad}
} catch (SomeException e) {
throw new OurException("It's all messed up dude " + e.getMessage());
}
{code}
{code:title=Good}
} catch (SomeException e) {
OurException oe = new OurException("It's all messed up dude " +
e.getMessage());
oe.initCause(e);
throw oe;
}
{code}
Once we move to 1.6 we can use the new exception constructors to set the init
cause at construction time rather than in a separate call.
> Rework physical plan
> --------------------
>
> Key: PIG-161
> URL: https://issues.apache.org/jira/browse/PIG-161
> Project: Pig
> Issue Type: Sub-task
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: arithmeticOperators.patch, incr2.patch, incr3.patch,
> Phy_AbsClass.patch, pogenerate.patch, pogenerate.patch, pogenerate.patch
>
>
> This bug tracks work to rework all of the physical operators as described in
> http://wiki.apache.org/pig/PigTypesFunctionalSpec
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
