[
https://issues.apache.org/jira/browse/PIG-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590767#action_12590767
]
Pi Song commented on PIG-202:
-----------------------------
Mathieu,
Ensuring all the specs instantiating what needed before use using a visitor
pattern is a good idea but just to make the code clean we should remove code
where those stuffs were previously instantiated as well.
For the MapreducePlanCompiler thing, you've got very good eyes. Now I also
tempted to add that comparator instantiation. Can you prove that at the moment
the quantilejob doesn't really sort based on the given function? Possibly a
small unit test would be enough.
In regard to the test, currently we only test either MapReduce or Local at a
time. That's why a bug such like this still occurs. In the mean time, I think
you should send an email to the mailing list so we can find a global solution
for all the tests together.
PS. Could you please combine all the needed patches? Too many fragments will
make it difficult for our already busy committers.
> ComparatorFunc provided to ORDER clause is not always honoured
> --------------------------------------------------------------
>
> Key: PIG-202
> URL: https://issues.apache.org/jira/browse/PIG-202
> Project: Pig
> Issue Type: Bug
> Reporter: Mathieu Poumeyrol
> Attachments: EvalSpec.patch, InstantiateFunc.patch,
> MapreducePlanCompiler.patch, TestOderBy.patch
>
>
> Specifying a comparator function is acknowledge neither by local
> implementation, nor by quartile lookup job.
> Patch coming soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
