[
https://issues.apache.org/jira/browse/PIG-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598091#action_12598091
]
Santhosh Srinivasan commented on PIG-159:
-----------------------------------------
1. Alan added the check for DOUBLE in isAtomicType(). Thanks for pointing it
out.
2. I will fix that. You are right, the order is not preserved if I traverse the
plan to get the inputs.
3. I also see a LOForEach. Is that your complete query?
4. LOProject stores a reference to its input. In your example, the second and
third projections will have a reference to the LOProject which retrieves the
columns a and b from the input c (a top level operator). The inner project
operators will store a reference to c. It should look like this:
Project(0 sentinel=true, c)
Project(0,1 sentinel=false, Project(1, sentinel = true, c))
Project(0,1 sentinel=false, Project(2, sentinel = true, c))
5. I need to think about this.
6. Thanks for pointing it out. Its broken in the existing parser too. I will
fix that
> Make changes to the parser to support new types functionality
> -------------------------------------------------------------
>
> Key: PIG-159
> URL: https://issues.apache.org/jira/browse/PIG-159
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: parser_chages_v5.patch, parser_chages_v6.patch,
> parser_chages_v7.patch, parser_chages_v8.patch, parser_chages_v9.patch
>
>
> In order to support the new types functionality described in
> http://wiki.apache.org/pig/PigTypesFunctionalSpec, the parse needs to change
> in the following ways:
> 1) AS needs to support types in addition to aliases. So where previously it
> was legal to say:
> a = load 'myfile' as a, b, c;
> it will now also be legal to say
> a = load 'myfile' as a integer, b float, c chararray;
> 2) Non string constants need to be supported. This includes non-string
> atomic types (integer, long, float, double) and the non-atomic types bags,
> tuples, and maps.
> 3) A cast operator needs to be added so that fields can be explicitly casted.
> 4) Changes to DEFINE, to allow users to declare arguments and return types
> for UDFs
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
