[ 
https://issues.apache.org/jira/browse/PIG-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600384#action_12600384
 ] 

daijy edited comment on PIG-243 at 5/28/08 9:03 AM:
-----------------------------------------------------------

Attached patch fix most problems under cygwin. 4 errors remaining in 
TestStreaming for map-reduce testing under cygwin need further work. Patch is 
tested in both Linux and Cygwin. Here is a list of detected problem and 
solution:
||Problem||Affected Testcase||Solution||
|Windows path delimit "\" interpreted as escape in 
java|TestMapReduceResultRecycling, TestMapReduce, TestOrderBy, TestBuiltin, 
TestFilterOpNumeric, TestBinaryStorage, TestFilterOpString, TestEvalPipeline, 
TestPigFile, TestReversibleLoadStore, TestAlgebraicEval, TestLargeFile, 
TestCombiner, TestPi |replace "\" with "\\", see 
[http://issues.apache.org/jira/browse/PIG-152]|
| Runtime.exec(String[]) fail for perl -e if perl statement include quote 
character for unknown reason |TestParamSubPreproc, TestStreaming|append a 
escape character \ to quote character " under Windows|
| There is a tailing CR (ascii: 0d) character for line read from text file 
under cygwin|TestBuiltin, TestEvalPipeline, TestPigSplit, TestStreaming|remove 
tailing 0x0d |
| Bug: forget to close output stream, following deletion operation 
fail|TestBinaryStorage|Fix bug |

Only one change to PigStorage.java (to fix tailing 0x0d) is inside core code. 
All other changes are in testcase. 

      was (Author: daijy):
    Attached patch fix most problems under cygwin. 4 errors remaining in 
TestStreaming for map-reduce testing under cygwin need further work. Patch is 
tested in both Linux and Cygwin. Here is a list of detected problem and 
solution:
||Problem||Affected Testcase||Solution||
|Windows path delimit "\" interpreted as escape in 
java|TestMapReduceResultRecycling, TestMapReduce, TestOrderBy, TestBuiltin, 
TestFilterOpNumeric, TestBinaryStorage, TestFilterOpString, TestEvalPipeline, 
TestPigFile, TestReversibleLoadStore, TestAlgebraicEval, TestLargeFile, 
TestCombiner, TestPi |replace "\" with "\\", see 
[http://issues.apache.org/jira/browse/PIG-152]|
| Runtime.exec(String[]) fail for perl -e if perl statement include quote 
character for unknown reason |TestParamSubPreproc, TestStreaming|append a 
escape character \ to quote character " |
| There is a tailing CR (ascii: 0d) character for line read from text file 
under cygwin|TestBuiltin, TestEvalPipeline, TestPigSplit, TestStreaming|remove 
tailing 0x0d |
| Bug: forget to close output stream, following deletion operation 
fail|TestBinaryStorage|Fix bug |

Only one change to PigStorage.java (to fix tailing 0x0d) is inside core code. 
All other changes are in testcase. 
  
> Make pig work on Windows
> ------------------------
>
>                 Key: PIG-243
>                 URL: https://issues.apache.org/jira/browse/PIG-243
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG_243.patch
>
>
> Currently a large number of unit tests is failing on Windows. We need to fix 
> that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to