[
https://issues.apache.org/jira/browse/PIG-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604517#action_12604517
]
Shravan Matthur Narayanamurthy commented on PIG-262:
----------------------------------------------------
Neat!!
I just had a couple of minor comments
1) In the java doc you say that PlanOptimizer need not be subclassed but you do
so for the LogicalOptimizer. Wasn't just a plan optimizer with
LogicalTransformer sufficient?
2) The rule in the LogicalOptiizer is wrong. Line 43 in LogicalOptimizer
should be nodes.add(LOLoad.class.getName());
3) Like Pi said we are entirely trusting the optimizer to insert right types. I
guess we need to run two passes of the type checker once before the optimizer
and once after.
> Pig needs an optimizer
> ----------------------
>
> Key: PIG-262
> URL: https://issues.apache.org/jira/browse/PIG-262
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: optimizer.patch
>
>
> We need to add an optimizer to pig. This will enable us to do some
> traditional optimizations, such as filter and projection pushing, join order
> and execution choices, etc. It will also enable optimizations specific to
> map/reduce (such as using the combiner).
> The optimizer will need to operate at various levels, including the logical,
> physical, and possibly map/reduce plan levels.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
