[
https://issues.apache.org/jira/browse/PIG-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608491#action_12608491
]
Santhosh Srinivasan commented on PIG-278:
-----------------------------------------
In the Schema.FieldSchema equals() method, the comparison of fschema.alias
should be with fother.alias and not with fschema.alias itself. I have marked
those lines with "<-- should be fother.alias" in the code below.
{code}
+ if (!relaxAlias) {
+ if ( (fschema.alias == null) &&
+ (fschema.alias == null) ) { <-- should be fother.alias
+ // good
+ }
+ else if ( (fschema.alias != null) &&
+ (fschema.alias == null) ) { <-- should be
fother.alias
+ return false ;
+ }
+ else if ( (fschema.alias == null) &&
+ (fschema.alias != null) ) { <-- should be
fother.alias
+ return false ;
+ }
+ else if (!fschema.alias.equals(fschema.alias)) { <-- should be
fother.alias
+ return false ;
+ }
{code}
> Allow no alias in Dot schema definition in Dot LogicalPlanLoader
> ----------------------------------------------------------------
>
> Key: PIG-278
> URL: https://issues.apache.org/jira/browse/PIG-278
> Project: Pig
> Issue Type: Bug
> Reporter: Pi Song
> Attachments: AllowNoAliasSchemaInDot.patch
>
>
> Our schema parser doesn't allow "null" alias but we have to be able to do
> that in Dot test files.
> This is a work around by introducing "[NoAlias]" keyword in schema definition
> just for Dot LogicalPlanLoader.
> Sample:-
> {noformat}
> foreach [ key="20", type="LOForEach" , schema="[NoAlias] : long, [NoAlias] :
> byteArray" ] ;
> {noformat}
> At runtime, [NoAlias] will be substituted by dummy column names before being
> sent to the parser. Subsequently those names will be replaced by "null".
> There is no changes in the actual query parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
