[
https://issues.apache.org/jira/browse/PIG-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Santhosh Srinivasan updated PIG-290:
------------------------------------
Attachment: insert_between.patch
The insert_between.patch fixes the following:
1. Changes the implementation of insertBetween in OperatorPlan.java so that the
ordering of the predecessors is not changed
2. Changed log.info in LOForeach getSchema() to log.debug. One of my earlier
patches had the log.info
3. Removed a printPlan use in TestLogicalPlanBuilder.java
The unit tests that still fail are:
[junit] Running org.apache.pig.test.TestEvalPipeline
[junit] Tests run: 8, Failures: 0, Errors: 1, Time elapsed: 141.926 sec
[junit] Test org.apache.pig.test.TestEvalPipeline FAILED
[junit] Running org.apache.pig.test.TestFilterOpNumeric
[junit] Tests run: 8, Failures: 0, Errors: 1, Time elapsed: 56.446 sec
[junit] Test org.apache.pig.test.TestFilterOpNumeric FAILED
[junit] Running org.apache.pig.test.TestStoreOld
[junit] Tests run: 3, Failures: 0, Errors: 2, Time elapsed: 39.782 sec
[junit] Test org.apache.pig.test.TestStoreOld FAILED
> LOCross output schema is not right
> ----------------------------------
>
> Key: PIG-290
> URL: https://issues.apache.org/jira/browse/PIG-290
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: types_branch
> Reporter: Pi Song
> Assignee: Santhosh Srinivasan
> Attachments: insert_between.patch
>
>
> From the schema generation code:-
> {noformat}
> List<LogicalOperator> inputs = mPlan.getPredecessors(this);
> for (LogicalOperator op : inputs) {
> // Create schema here
> }
> {noformat}
> The output schema is generated based on inputs determined in the logical
> plan. However, mPlan.getPredecessors() doesn't always preserve the right
> order (A x B and B x A result in different schemas). I suggest maintaining
> mInputs variable in LOCross (as it used to be) to resolve this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
