[ 
https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Attachment: PIG-336-part1_v4.patch

Attached patch to address review comments.
Delta to previous patch:


- Removed TestOrderBy changes - we should revisit this after order desc is fixed

- NullableXXX classes have a change in the compareTo():
If both the objects being compared are nulls, it returns a 0 - this enables all 
nulls to collapse during a group by

-keyDiscoverKeyTypeVisitor has been changed to visit MROperPlan
 Supporting changes are in JobControlCompiler, PigMapBase, 
LocalLauncher,MapReduceLauncher, MapReduceOper, PigCombiner, 

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, 
> PIG-336-part1_v3.patch, PIG-336-part1_v4.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to