[
https://issues.apache.org/jira/browse/PIG-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632774#action_12632774
]
Olga Natkovich commented on PIG-361:
------------------------------------
+1 on the patch
Couple of small comments:
(1) NullableBag and NullableTuple can use static factory to avoid "if" on every
bag/tuple construction
(2) Index is currenty attached to all data even if we only have 1 stream. It is
only a single byte but we could optimize a bit further here later
> JOIN and cogroup should handle NULLs correctly
> ----------------------------------------------
>
> Key: PIG-361
> URL: https://issues.apache.org/jira/browse/PIG-361
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: types_branch
> Reporter: Pradeep Kamath
> Assignee: Alan Gates
> Priority: Critical
> Fix For: types_branch
>
> Attachments: PIG-361.patch
>
>
> JOIN should follow SQL semantics .i.e if the join key is a null or part of
> the join key is null in the first table, it should not join with similar keys
> in the second table.
> Cogroup should coalesce all NULL key rows into one group.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
