[
https://issues.apache.org/jira/browse/PIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633395#action_12633395
]
Olga Natkovich commented on PIG-427:
------------------------------------
Looks good. A couple of comments
(1) exact schema match comparison should be made before bytearray comparison.
You can have a UDF that takes a bytearray as parameter. In that case it does
not matter how many functions are present in the table.
(2) it would be good to have comment explaining what the rules are about
bytearrays and also about multiple matches
(3) Looks like the code is making an assumtion that scores will be returned in
the score order. I was not quite sure why.
> casting parameters of a UDF
> ---------------------------
>
> Key: PIG-427
> URL: https://issues.apache.org/jira/browse/PIG-427
> Project: Pig
> Issue Type: Improvement
> Affects Versions: types_branch
> Reporter: Olga Natkovich
> Assignee: Shravan Matthur Narayanamurthy
> Fix For: types_branch
>
> Attachments: 427-1.patch, 427.patch
>
>
> Currently if we have a UDF that declares via getArgToFuncMapping that it can
> only handle a subset of types, passing any other types to the function would
> result in an error. However, some types can be promoted to others and it
> would be useful if typechecker to perform best fit cast. For instance, if the
> input parameter has type of Long and the UDF support Int and Double, the code
> should cast the paraneter into Double.
> This would be very useful for conversion of the UDFs from the piigybank to
> the new code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
